search

ladybug-tools / spider

:spider_web: 3D interactive analysis in your browser mostly written around the Three.js JavaScript library
http://www.ladybug.tools/spider
44 stars 15 forks source link

'Aragog' gbXML Viewer R14.16 - review #146

Open mdengusiak opened 5 years ago

mdengusiak commented 5 years ago

@theo-armour

here is my review for R14.16

  1. can we add ability to hide in view and zoom to the top

  2. can we have as default only for surfaces by id

    • Surfacesorted by ID
    • Space by Name
    • Storey by Name
    • Zone by Name
    • Opening by ID

  3. udpate does not work for me, image

  4. when I laod files history is not clearing from here image

  5. can we adjust colors within theme: Sketch... I would like to use it for this release but adjust colors. I like transparency

  6. can we extend windows to see full name image

theo-armour commented 5 years ago

1 can we add ability to hide in view and zoom to the top?

See issue #147

2 can we have as default only for surfaces by id?

Test if OK in R14.17

3 update does not work for me,

It's not working for me either, Also not working in R13.

It's certainly a fixable problem but it's in a part of the code with twenty or more variables are in play. It will take me a day or so to get the code back into my head and another day or two fixing the code and testing and fixing. I think the reason I did not finish this work before is because the emphasis moved toward ways of fixing things with automation rather than by hand.

If you need to fix things by hand, it's probably safer to stick to R12. If you want to help move things forward, then there is much work needed in simplifying the process started in R13/R14

In any case, feel free to continue the discussion.

4 when I load files history is not clearing from here

Fixed in R14.17

5 can we adjust colors within theme: Sketch... I would like to use it for this release but adjust colors. I like transparency

Here's a link to the Sketchy theme CSS source code:

See also

If you provide a list of the things you would like to see changed, I could have a go at editing the theme manually and seeing if the updates might work.

can we extend windows to see full name?

It looks like this issue may be theme dependent. ;-(

mdengusiak commented 5 years ago

@theo-armour

  1. TBC discussion is seperate posst #147

  2. I can see tags correct but display still name, correction required image

  3. Yes this is most important fuction - easy change and fix. . We have now two weeks. I would suggest we move to R15 impelment new quick egine, and make this simple and responsive sth we did in R12 however it was not super stable as saving files. Let me know if this is doable and we can curry on this discussion.

  4. approved, fix and tested :)

  5. TBC will have a think what would be worth adjust to make sure looks cool but for me point 3 is the most important