ladybug-tools / spider

:spider_web: 3D interactive analysis in your browser mostly written around the Three.js JavaScript library
http://www.ladybug.tools/spider
44 stars 15 forks source link

Editing Files #64

Closed theo-armour closed 6 years ago

theo-armour commented 6 years ago

@chiensiTB

create-exportable-buildings.html

I have just had a look at this file.

I note that you have merged a number of edits into the file.

I am happy that you are taking the time and effort to improve the script.

Please note, however, that the usual way to collaborate is to fork a file and make edits on the new copy,

If you wish to edit the original file, it's best to seek an OK from the authors first and agree methods of collaboration prior to committing.

chiensiTB commented 6 years ago

I've forked it.

chiensiTB commented 6 years ago

I was in a rush, sorry, and the way this project is setup is unusual, I was trying to generate maximal value in the shortest amount of time, committing was the only way I can see my changes take effect.