search

ladybug-tools / spider

:spider_web: 3D interactive analysis in your browser mostly written around the Three.js JavaScript library
http://www.ladybug.tools/spider
44 stars 15 forks source link

gbXML Viewer R11.6 ~ pre-release ~ Save Changes Sample Files #85

Closed theo-armour closed 6 years ago

theo-armour commented 6 years ago

@mdengusiak

Save Changes is a new feature in R11.

gbXML Viewer Save Changes Samples Read Me

This file covers:

I hope these thoughts help with your testing

mdengusiak commented 6 years ago

@theo-armour this is great and clean explanation. I am also focusing on testing saving changes as this is what we normally wil do.

Here is first problem to solve: I deleted shade surface and adjusted Airto ExternalWall and modified CADObjectID

image

All changes are saved apart from CADObjectID it shows as not modifed

image

I changed again and then click on another surface and back again and here we are is not saving chage: image

theo-armour commented 6 years ago

can you send me the json that did not work?

On Wed, Mar 7, 2018 at 12:31 AM, Michal Dengusiak notifications@github.com wrote:

@theo-armour https://github.com/theo-armour this is great and clean explanation. I am also focusing on testing saving changes as this is what we normally wil do.

Here is first problem to solve: I deleted shade surface and adjusted Airto ExternalWall and modified CADObjectID

[image: image] https://user-images.githubusercontent.com/14005893/37081482-7b8cd986-21e1-11e8-8875-46960b59531c.png

All changes are saved apart from CADObjectID it shows as not modifed

[image: image] https://user-images.githubusercontent.com/14005893/37081493-86adda2c-21e1-11e8-8d45-75180f84753a.png

I changed again and then click on another surface and back again and here we are is not saving chage: [image: image] https://user-images.githubusercontent.com/14005893/37081583-cff9d06e-21e1-11e8-8181-da1b14db7c05.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ladybug-tools/spider/issues/85#issuecomment-371062423, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhbKplRmSvV5JdCOszsCW84nsmS5x-2ks5tb5rqgaJpZM4Sf6RC .

mdengusiak commented 6 years ago

@theo-armour, sure: aim0013-changes (2).zip

mdengusiak commented 6 years ago

@theo-armour tested and works excellent