ladybug-tools / uwg

:city_sunrise: The Urban Weather Generator (uwg) is a Python application for modeling the urban heat island effect.

https://www.ladybug.tools/uwg/docs/

GNU General Public License v3.0

56 stars 26 forks source link

Possible error in uwg.py #248

Closed gianlucamaracchini closed 3 years ago

gianlucamaracchini commented 3 years ago

Hi, I found this in uwg.py.

fraction of vegetation (tree & grass) coverage on unbuilt surface

    road_veg_coverage = self.vegcover / (1 - self.blddensity)
    road_grass_coverage = self.treecover / (1 - self.blddensity)
    road_tree_coverage = self.grasscover / (1 - self.blddensity)

It would seem that self.grasscover and self.treecover are inverted.

Thanks, G.

saeranv commented 3 years ago

@jmrk87

Yeah I agree, that looks like a bug, and may actually explain some weird behaviour I've seen with tree/grass fractions before.

chriswmackey commented 3 years ago

Thanks @jmrk87 and @saeranv . I'm fixing this one now.