search

ladyson / Movie_App

0 stars 0 forks source link

Submitting movie app HW #1

Open ladyson opened 10 years ago

ladyson commented 10 years ago

@gtolle

gtolle commented 10 years ago

Hi Lauren,

Just checked out your movies app. It gets the job done, and I didn't see any problems.

For next time, you might want to look into using Bootstrap to style your pages a bit more, and look into application.html.erb to get a common site logo on each page, common nav bar, etc.

Also, your 'View All Movies' link should probably just link back to root_path instead of to movies/index. That way the user gets the usual URL when they're seeing all the movies.

Gil

On Thu, Nov 21, 2013 at 4:50 PM, ladyson notifications@github.com wrote:

@gtolle https://github.com/gtolle

— Reply to this email directly or view it on GitHubhttps://github.com/ladyson/Movie_App/issues/1 .

gtolle commented 10 years ago

Oh, and I don't think I got a Heroku URL from you. Could you push it up to Heroku and send it over?

Thanks, Gil

On Sun, Nov 24, 2013 at 11:17 PM, Gilman Tolle gilman.tolle@gmail.comwrote:

Hi Lauren,

Just checked out your movies app. It gets the job done, and I didn't see any problems.

For next time, you might want to look into using Bootstrap to style your pages a bit more, and look into application.html.erb to get a common site logo on each page, common nav bar, etc.

Also, your 'View All Movies' link should probably just link back to root_path instead of to movies/index. That way the user gets the usual URL when they're seeing all the movies.

Gil

On Thu, Nov 21, 2013 at 4:50 PM, ladyson notifications@github.com wrote:

@gtolle https://github.com/gtolle

— Reply to this email directly or view it on GitHubhttps://github.com/ladyson/Movie_App/issues/1 .