generate offline documentation during deployment

lae / ansible-role-netbox

Cross-platform Ansible role for deploying NetBox, a DCIM/IPAM tool, in a production environment.

MIT License

200 stars 72 forks source link

generate offline documentation during deployment #142

Closed karolyczovek closed 2 years ago

karolyczovek commented 2 years ago

LGTM, but I want to double check on one thing. The last commit changes the version gate from 3.1.0 to 2.12.0. > It looks like the mkdocs commit was added to 3.0.0, so shouldn't it be set to that? (and 2.12.0 doesn't look like >it exists) What's the reasoning behind that?

Might be i interpret wrong, https://github.com/netbox-community/netbox/issues/6328 mentions docs generation as 2.11 feature - this was the reasoning behind.

lae commented 2 years ago

Nah, the version specified in that issue is just what the current version of Netbox was when that person opened a feature request. If you look at the commit, https://github.com/netbox-community/netbox/commit/7058d6ca5ae2901383874bcea5fedad31e165dca, it'll show you what tags it is under and the earliest seems to be 3.0-beta1. Anyway, merging this, thanks.