search

lae / ansible-role-proxmox

IaC for Proxmox VE clusters.
MIT License
468 stars 139 forks source link

FIX new_kernel_exists in collect_kernel_info always returns true #208

Closed pielas closed 1 year ago

pielas commented 1 year ago

collect_kernel_info module reported kernel change(new_kernel_exists set to true) even in case when kernel did not change.

lae commented 1 year ago

Duplicate of #206? I was waiting for someone to review that and then forgot about it, actually...

pielas commented 1 year ago

Ah, it looks so. I only checked if it's fixed on develop :)

lae commented 1 year ago

Does that other PR look fine codewise and does it work for you, then? I think the decode("utf-8") isn't necessary because Ansible's to_text() method should take care of it, iirc.

pielas commented 1 year ago

@lae yes, I wanted explicit conversion to string, but indeed it seems that it isn't necessary and for my case adding parentheses is enough

lae commented 1 year ago

Ok thank you, I merged the other PR into develop, which I've actually been using for the past two months without issue (merged locally) now that I think about it.