search

lae / ansible-role-proxmox

IaC for Proxmox VE clusters.
MIT License
468 stars 139 forks source link

Fix host used to configure HA groups #219

Closed btravouillon closed 4 months ago

btravouillon commented 1 year ago

When the role is run with --limit nodes_without_first_node, the HA groups are not configured (tasks are skipped). Use _init_node instead of groups[pve_group][0] to run the tasks.

_init_node is any active node in an already initialized Proxmox cluster which is part of the run.

lae commented 1 year ago

Correct me if I'm wrong, but this looks like a possible QoL improvement throughout the entire role, actually, and not just for these tasks.

The tasks in main.yml that are run against the first cluster node probably could make use of this change. Do you think you can expand the scope of this to all tasks that reference groups[pve_group][0]?

lae commented 1 year ago

@btravouillon since it's been some time, am I okay to assume your +1 is to indicate that you'll update this PR with what I suggested sometime?

btravouillon commented 1 year ago

Oh yes, sorry. I'm quite busy this week but I'll try to take a look at this asap.

lae commented 1 year ago

no problem, just checking. take your time.

lae commented 4 months ago

Looks like my vagrant setup is broken, but these changes seem trivial so I'll merge without testing.