search

lae / ansible-role-proxmox

IaC for Proxmox VE clusters.
MIT License
516 stars 146 forks source link

GRUB_CMDLINE_LINUX lines getting duplicated #274

Open lae opened 1 month ago

lae commented 1 month ago

Not sure when this started occurring, but my workstation's /etc/default/grub seems to be having deduplication issues:

GRUB_CMDLINE_LINUX_DEFAULT=""
GRUB_CMDLINE_LINUX="root=ZFS=rpool/ROOT/pve-1 console=ttyS1,115200n8 console=tty0 amd_iommu=on iommu=pt vfio-pci.ids=<redacted> pci.stub.ids=<redacted> nmi_watchdog=0 hugepagesz=1G default_hugepagesz=2M nmi_watchdog=0 nmi_watchdog=0"
GRUB_CMDLINE_LINUX="root=ZFS=rpool/ROOT/pve-1 console=ttyS1,115200n8 console=tty0 amd_iommu=on iommu=pt vfio-pci.ids=<redacted> pci.stub.ids=<redacted> nmi_watchdog=0 hugepagesz=1G default_hugepagesz=2M nmi_watchdog=0 nmi_watchdog=0"
GRUB_CMDLINE_LINUX="root=ZFS=rpool/ROOT/pve-1 console=ttyS1,115200n8 console=tty0 amd_iommu=on iommu=pt vfio-pci.ids=<redacted> pci.stub.ids=<redacted> nmi_watchdog=0 hugepagesz=1G default_hugepagesz=2M nmi_watchdog=0 nmi_watchdog=0"
GRUB_CMDLINE_LINUX="root=ZFS=rpool/ROOT/pve-1 console=ttyS1,115200n8 console=tty0 amd_iommu=on iommu=pt vfio-pci.ids=<redacted> pci.stub.ids=<redacted> nmi_watchdog=0 hugepagesz=1G default_hugepagesz=2M nmi_watchdog=0 nmi_watchdog=0"
GRUB_CMDLINE_LINUX="root=ZFS=rpool/ROOT/pve-1 console=ttyS1,115200n8 console=tty0 amd_iommu=on iommu=pt vfio-pci.ids=<redacted> pci.stub.ids=<redacted> nmi_watchdog=0 hugepagesz=1G default_hugepagesz=2M nmi_watchdog=0 nmi_watchdog=0"
GRUB_CMDLINE_LINUX="root=ZFS=rpool/ROOT/pve-1 console=ttyS1,115200n8 console=tty0 amd_iommu=on iommu=pt vfio-pci.ids=<redacted> pci.stub.ids=<redacted> nmi_watchdog=0 hugepagesz=1G default_hugepagesz=2M nmi_watchdog=0 nmi_watchdog=0"
GRUB_CMDLINE_LINUX="root=ZFS=rpool/ROOT/pve-1 console=ttyS1,115200n8 console=tty0 amd_iommu=on iommu=pt vfio-pci.ids=<redacted> pci.stub.ids=<redacted> nmi_watchdog=0 hugepagesz=1G default_hugepagesz=2M nmi_watchdog=0 nmi_watchdog=0"
GRUB_CMDLINE_LINUX="$GRUB_CMDLINE_LINUX nmi_watchdog=0"

Role variables:

pve_group: pve_standalone
pve_cluster_enabled: false
pve_extra_packages:
  - nfs-kernel-server
pve_watchdog: ipmi
pve_zfs_enabled: true
pve_zfs_options: zfs_arc_max=17179869184
pve_run_system_upgrades: true

I haven't updated my playbook to use the new VFIO role variables so that's probably not it. I think I have an idea where this is happening, but I was wondering if anyone else is getting their grub config flooded, too (and if so, then should we try to clean it up?).