Fedora support, closes #13

lae / ansible-role-travis-lxc

Ansible role that prepares a Travis CI environment and creates LXC containers for testing roles.

MIT License

4 stars 2 forks source link

Fedora support, closes #13 #14

Closed wilmardo closed 6 years ago

wilmardo commented 6 years ago

Fixes issue #13
Adds network_config variable as discussed in issue #13
Normalized --release tag (removed the -R shorthand used in some of the template_options)
with_items added to pip task, seems more logical since the travis_lxc_eggs is a list

lae commented 6 years ago

Can you namespace network_config so that it becomes travis_lxc_network_config?

wilmardo commented 6 years ago

Done :+1: In my personal opinion the variables in defaults.yml need to be prefixed as well, to prevent duplicate variables in a playbook. What is your opinion on this? If you agree I will create a seperate pull request for this :)

lae commented 6 years ago

Yeah, typically I would too (I do so in my other roles), but I haven't thought of any use cases where this role would be used alongside other roles in a playbook (so I'm not sure I'd want to support them). It's probably not even necessary to namespace the variables in vars/ either, but I guess I was already using that convention there.