Closed m4rc1e closed 4 years ago
Okay, great, thank you. So looking at these issues one-by-one:
uni0252
isn't in this font; it has bullet
at uni2022
and bulletoperator
at uni2219
as a composite of bullet
. bullet
is a real glyph without components and bulletoperator
only has the single component.Okay, fixed 2 and 6, new issue with names:
**Check name table: TYPOGRAPHIC_SUBFAMILY_NAME entries.
* π₯ **FAIL** TYPOGRAPHIC_SUBFAMILY_NAME entry for Win "24pt Regular" must be "Regular". Please note, since the font style is RIBBI, this record can be safely deleted. [code: bad-win-name]*
but so where's the error?
π₯ FAIL: DESCRIPTION.en_us.html must have less than 1000 bytes.
Ignore
π₯ FAIL: Variable font weight coordinates must be multiples of 100.
Fix. Probably linked to the ExtraLight being 250
π₯ FAIL: A static fonts directory with at least two fonts must accompany variable fonts
Ignore. This is an issue with FB.
π₯ FAIL: Checking OS/2 Metrics match hhea Metrics.
Why not run grep on the dir with the values FB is finding? this should tell you which files you need to modify.
π₯ FAIL: Are there unwanted tables?
Use gftools fix-unwanted-tables
π₯ FAIL The following glyphs have duplicate components which have the same x,y coordinates: {'glyph': 'uni2052', 'component': 'bullet', 'x': 0, 'y': 0} [code: found-duplicates]
That glyph is in the font, it is the commercialMinusSign. Remember we're checking binaries so the glyph names may have been converted from human readable names to uni names.
Interestingly the glyph has been marked as non-exportable. I guess fontmake ignores this. If you don't need this glyph, you may as well delete it.
Why not run grep on the dir with the values FB is finding? this should tell you which files you need to modify.
Hey, great idea. π
I'll delete the commercialMinusSign
.
Thanks Marc.
Okay, fixed 2 and 6, new issue with names: so where's the error?
Remember these checks are broken for multi axes vfs so I'm rewriting them.
As long as the instances comply to https://gist.github.com/m4rc1e/8f4c4498519e8a36cd54e16a004275cb#instance-names I'm happy.
Excellent. Thanks again.
Hey @m4rc1e, I now have a clean build except for fontbakery disliking 200 as a weight and the lack of a statics directory.
Thanks!
Fontbakery report
Fontbakery version: 0.7.18
[1] Family checks
β WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?
* [com.google.fonts/check/ftxvalidator_is_available](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/ftxvalidator_is_available) * β **WARN** ftxvalidator is not available.[10] Russolo[opsz,wght].ttf
π₯ FAIL: DESCRIPTION.en_us.html must have less than 1000 bytes.
* [com.google.fonts/check/description/max_length](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/description/max_length) * π₯ **FAIL** DESCRIPTION.en_us.html must have size smaller than 1000 bytes. [code: too-long]π₯ FAIL: Variable font weight coordinates must be multiples of 100.
* [com.google.fonts/check/varfont_weight_instances](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/varfont_weight_instances) * π₯ **FAIL** Found a variable font instance with 'wght'=275.0. This should instead be a multiple of 100. [code: bad-coordinate] * π₯ **FAIL** Found a variable font instance with 'wght'=275.0. This should instead be a multiple of 100. [code: bad-coordinate] * π₯ **FAIL** Found a variable font instance with 'wght'=275.0. This should instead be a multiple of 100. [code: bad-coordinate]π₯ FAIL: A static fonts directory with at least two fonts must accompany variable fonts
* [com.google.fonts/check/repo/vf_has_static_fonts](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/repo/vf_has_static_fonts) * π₯ **FAIL** Please create a subdirectory called "static/" and include in it static font files. [code: missing]π₯ FAIL: Check variable font instances have correct coordinate values
* [com.google.fonts/check/varfont_instance_coordinates](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/varfont_instance_coordinates) * π₯ **FAIL** Instance "10pt ExtraLight" wght value is "275.0". It should be "200.0" [code: bad-coordinate] * π₯ **FAIL** Instance "24pt ExtraLight" wght value is "275.0". It should be "200.0" [code: bad-coordinate] * π₯ **FAIL** Instance "72pt ExtraLight" wght value is "275.0". It should be "200.0" [code: bad-coordinate]π₯ FAIL: Checking OS/2 Metrics match hhea Metrics.
* [com.google.fonts/check/os2_metrics_match_hhea](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/os2_metrics_match_hhea) * π₯ **FAIL** OS/2 sTypoDescender (-486) and hhea descent (-526) must be equal. [code: descender]π₯ FAIL: Are there unwanted tables?
* [com.google.fonts/check/unwanted_tables](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/unwanted_tables) * π₯ **FAIL** The following unwanted font tables were found: Table: MVAR Reason: Produces a bug in DirectWrite which causes https://bugzilla.mozilla.org/show_bug.cgi?id=1492477, https://github.com/google/fonts/issues/2085 They can be removed with the gftools fix-unwanted-tables script.π₯ FAIL: Check glyphs do not have duplicate components which have the same x,y coordinates.
* [com.google.fonts/check/glyf_non_transformed_duplicate_components](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/glyf.html#com.google.fonts/check/glyf_non_transformed_duplicate_components) * π₯ **FAIL** The following glyphs have duplicate components which have the same x,y coordinates: * {'glyph': 'uni2052', 'component': 'bullet', 'x': 0, 'y': 0} [code: found-duplicates]β WARN: Is there kerning info for non-ligated sequences?
* [com.google.fonts/check/kerning_for_non_ligated_sequences](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/kerning_for_non_ligated_sequences) * β **WARN** GPOS table lacks kerning info for the following non-ligated sequences: - f + f - f + i - i + f - f + l - l + f - i + l [code: lacks-kern-info]β WARN: Combined length of family and style must not exceed 27 characters.
* [com.google.fonts/check/name/family_and_style_max_length](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/name/family_and_style_max_length) * β **WARN** The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries: FONT_FAMILY_NAME = 'Russolo 10pt ExtraLight' / SUBFAMILY_NAME = 'Regular' Please take a look at the conversation at https://github.com/googlefonts/fontbakery/issues/2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]β WARN: Checking Vertical Metric Linegaps.
* [com.google.fonts/check/linegaps](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/hhea.html#com.google.fonts/check/linegaps) * β **WARN** OS/2 sTypoLineGap is not equal to 0. [code: OS/2]Summary
Note: The following loglevels were omitted in this report:
Diff images: russolo_qa.zip