search

lafeber / world-flags-sprite

A sprite of all the worlds' flags.
http://cheesewiki.com/
Other
593 stars 168 forks source link

New version for flags without borders #38

Open JimmyAXE opened 9 years ago

JimmyAXE commented 9 years ago

I just discover that you've removed those 1px light grey borders from all flags in latest commit (https://github.com/lafeber/world-flags-sprite/commit/96a9bc89abd1368c00799db0b9c4998cb2697b42), which is fine, but could you please make a new version out of it? My older designs are suited for images with borders, so it looks weird now, especially when you've got a flag with white space on white background for example.

aloxe commented 9 years ago

I see the problem you pointed and I made that change. Unfortunately it seams that my image editor doesn't read the shadows around flags and I can't figure out why. I need some help here.

tudorpavel commented 9 years ago

I also had some problems with that. But I think it wasn't because of Gimp itself, it was because of the compression step.

I'm not sure if this was my solution in the end, but I used the older uncompressed images, made my changes and compressed them afterwards with the same tool: https://compressor.io/compress.

The only problem is that this isn't really feasible for the future, as new flags are added, only if an uncompressed version is also kept up to date inside the repo. What do you think, @lafeber?

lafeber commented 9 years ago

Very good idea to have the uncompressed images in the repo! This ensures quality in the future. Plus, people may choose a higher quality image if they don't care about bandwidth or page speed.

tudorpavel commented 9 years ago

@lafeber, do you also have a PSD template or something like that with the glow&shadow effect of flags?

Including a template (maybe as a TIFF for compatibility) in the repo would also greatly simplify contribs such as @aloxe's.

micky2be commented 7 years ago

Any plan to add the shadows back?