lagadic / vision_visp

ViSP stack for ROS
http://wiki.ros.org/vision_visp
GNU General Public License v2.0
184 stars 90 forks source link

visp_auto_tracker: Overwritting object position's frame id #96

Open Pyrojambo opened 5 years ago

Pyrojambo commented 5 years ago

What is the reason for overwriting the frame_id in the header of the PoseStamped message for in line 194 - 196 of node.cpp of the vision_auto_tracker?

ps.header = image_header_;
ps.header.frame_id = tracker_ref_frame;
object_pose_publisher.publish(ps);

The tracker_ref_frame is set to "\map" in names.cpp which overwrites whatever frame the image (and therefore the pose calculated) used as a reference. The same is also done to the covariance position.

fspindle commented 5 years ago

To have pose and covariance corresponding to the processed image timestamp

Pyrojambo commented 5 years ago

The timestamp is copied to the pose with ps.header = image_header_. My question is the next line (ps.header.frame_id = tracker_ref_frame;) where you overwrite the reference frame from the image's reference frame to "/map". A quick example of what I mean is:

fspindle commented 5 years ago

Sorry, I miss read your first message.

I don't see any good reason to overwrite frame_id.

nickvaras commented 5 years ago

97

YikaiZengTUD commented 1 year ago

Hi, I am encountering the same issue regarding the fixed frame id. Are there any updates and could it be configurable in the launch file?

-- After reading the commits, it could be configured in the launch file for the node by

 <param name="tracker_ref_frame" value="the name you want"/>

Thanks for your efforts and I may suggest adding this line in the tutorials