search

lageIBUSP / Rsampling

R package to reproduce the Resampling Stats Add-in
2 stars 9 forks source link

updated docs #11

Closed piklprado closed 9 years ago

piklprado commented 9 years ago

Vignetes now uses the nice function dplot from PR #9. Also corrected a broken code (\link{\code()} instead of \code{\link{}} in man dplot and did some other minor changes in documentation. Also included Chalom and Oliveira as authors. With all this I ran build_vignetes() and document() and all needed files seems updated, including NAMESPACE. So PR #10 does not seem necessary anymore.

andrechalom commented 9 years ago

Seems ok to me, but I don't have write access to the repository.

I've noticed that the values of the randomized distribution have changed from the last build_vignettes() to this one. Should we include a set.seed(42) to keep results reproducible?

One last comment, it seems that you are using a slightly outdated version of roxygen, maybe it would be beneficial to upgrade it to guarantee that everyone in the team is able to generate exactly the same documentation files.

piklprado commented 9 years ago

Sorry, I forgot to invite you and Alê, now its is done. set.seed(42) included in the vignetes, but to update roxygen I need to update R and I'll do that later. I accepted the request because the rush of the field course.

adalardo commented 9 years ago

Ok for me!