lageIBUSP / Rsampling

R package to reproduce the Resampling Stats Add-in
2 stars 9 forks source link

Fixing issues detected by CRAN #29

Closed piklprado closed 8 years ago

piklprado commented 8 years ago

Email from CRAN Mantainers:

We get

No package encoding and non-ASCII characters in the following R files: R/data_documentation.R 18: #' Kondrat, H. 2012. Estmulos qumicos de folhas novas promovem recrutamento eficiente de formigas associadas embaba 19: #' \emph{Cecropia glaziovi} (Urticaceae). Curso de campo "Ecologia da Mata Atlntica" 20: #' (G. Machado; P.I. Prado & A.M.Z. Martini, eds.). Universidade de So Paulo, So Paulo. 41: #' Mello, T.J. 2012. Infestao por lianas e comportamento de poda por formigas em \emph{Cecropia} 42: #' (Urticaceae). Curso de campo "Ecologia da Mata Atlntica" 43: #' (G. Machado; P.I. Prado & A.M.Z. Martini, eds.). Universidade de So Paulo, So Paulo. 65: #' Werneck, R.T. 2010. Lar, viscoso lar. Experimento de seleo de habitat e forrageio de aranhas 66: #' em plantas com tricomas glandulares. Curso de campo "Ecologia da Mata Atlntica" 67: #' (G. Machado; P.I. Prado & A.A. Oliveira, eds.). Universidade de So Paulo, So Paulo. 88: #' Prado, A. \emph{et al}. 2013. Variaes na morfologia de sustentao em \emph{Rhizophora mangle} (Rizophoraceae) em diferentes 89: #' condies de inundao do solo. Curso de campo "Ecologia da Mata Atlntica" 90: #' (G. Machado, P.I. Prado & A.M.Z. Martini eds.). Universidade de So Paulo, So Paulo.

The Title field should be in title case, current version then in title case: 'Ports the workflow of "Resampling Stats" add-in to R' 'Ports the Workflow of "Resampling Stats" Add-in to R'

piklprado commented 8 years ago

I think adding Enconding:UTF-8 in DESCRIPTION solves the problem with non-ASCII characters. But since we have not detected this problem while checking in our machines and we also had enconding issues with vignettes please check.

andrechalom commented 8 years ago

From Writing R Extensions:

If the DESCRIPTION file is not entirely in ASCII it should contain an ‘Encoding’ field specifying an encoding. This is used as the encoding of the DESCRIPTION file itself and of the R and NAMESPACE files, and as the default encoding of .Rd files. The examples are assumed to be in this encoding when running R CMD check, and it is used for the encoding of the CITATION file. Only encoding names latin1, latin2 and UTF-8 are known to be portable. (Do not specify an encoding unless one is actually needed: doing so makes the package less portable. If a package has a specified encoding, you should run R CMD build etc in a locale using that encoding.)

So I guess the package will be accepted now.