Add exchange to get_historical_price (minute, hour, and day)

lagerfeuer / cryptocompare

Python3 Wrapper for the CryptoCompare API

MIT License

182 stars 74 forks source link

Add exchange to get_historical_price (minute, hour, and day) #33

Closed GiliR4t1qbit closed 4 years ago

GiliR4t1qbit commented 4 years ago

In the cryptocompare API, it's possible to pass the exchange via the e argument to get_historical_price_minute (hour and day), but not currently through this package. This addition needs to be made to each of those three functions, to the tests, and to the README.

I've made the (pretty straightforward) changes in this Pull Request: #32

GiliR4t1qbit commented 4 years ago

@lagerfeuer: The build failed due to failing to "Upload coverage report to coveralls.io". I can see that the tests passed, and they pass on my machine as well.

lagerfeuer commented 4 years ago

@GiliR4t1qbit Thank you for your contribution, I have merged this. And yes, the Upload step fails, I need to fix this in regards to Pull Requests.