search

laggardkernel / homebrew-tap

Personal tap for homebrew formulae
10 stars 3 forks source link

Upgrade iterm2-zmodem #3

Open guoquan opened 1 year ago

guoquan commented 1 year ago

Would you mind upgrade iterm2-zmodem to use current laggardkernel/iterm2-zmodem which support homebrew prefix path?

lance6716 commented 1 year ago

@laggardkernel Hi, I also meet this problem. Currently your script uses release v1.0.0, but https://github.com/laggardkernel/iterm2-zmodem/commit/1eae347d63f8d3111ea7765bcb6c81c4fda443f3 is really helpful

And another problem is https://github.com/laggardkernel/homebrew-tap/blob/afb2260ac09ad811a935dde39f0122c1026e754d/Formula/iterm2-zmodem.rb#L15-L29

The output is Regular expression: rz waiting to receive.**B0100 rather than Regular expression: rz waiting to receive.\*\*B0100. Seems should escape twice.

laggardkernel commented 1 year ago

Just updated the formula. Have a try.

I'm afraid the commit you mentioned is not a perfect solution. It still needs human intervention to export HOMEBREW_PREFIX manually. @lance6716

lance6716 commented 1 year ago

Thanks. Maybe an automatic way is to let the two scripts have a placeholder, and replace the placeholder with HOMEBREW_PREFIX when install it.

And I found https://iterm2.com/python-api/profile.html and https://github.com/gnachman/iTerm2/blob/320e08181342c1063506d5bba89d4973ac60fb99/api/library/python/iterm2/iterm2/triggers.py#L79 maybe the manually "Create triggers under Profiles" action can also be done automatically.

I will help at my spare time 😄