search

lago-project / lago

Ad-hoc virtual testing environment framework
http://lago.readthedocs.org
GNU General Public License v2.0
47 stars 39 forks source link

tests: update the cirros image #422

Open nvgoldin opened 7 years ago

nvgoldin commented 7 years ago

The cirros image is quite outdated and old(what we use was released in the beginning of 2015, which is the last official image release)

  1. Quoting from https://github.com/lago-project/lago/pull/419 some stuff we might find useful in the current master:

    I still have no doubt that we need to try with newer cirros images (true, they have not released one in ages, but they are available). Examples of potentially relevant commits: https://git.launchpad.net/cirros/commit/?id=4285160b0d0b7f9be19f7464b61df3ad1decd3cb - IPv6 information https://git.launchpad.net/cirros/commit/?id=6752f081363a0d38b1dd41593b47ac60b0caab52 - virtio-SCSI (which we need!) https://git.launchpad.net/cirros/commit/?id=c475073deef2e45ffc61d469a0b6254a365a6d2c - another fix in DHCP ... https://git.launchpad.net/cirros/commit/?id=2d3e303f5f940c411feaa74917988f8c397a2ef4 - much newer kernel

  2. Ensure dhcp client is working properly, some relevant bugs at cirros: https://bugs.launchpad.net/cirros/+bug/1273159 https://bugs.launchpad.net/cirros/+bug/1224618

ifireball commented 7 years ago

The cost of this is a whole new image added to the Git history while still keeping the old image there.

Bottom line - having "hard-coded" the image binary in the source repo, we're stuck with it.

nvgoldin commented 7 years ago

@ifireball - that is true, but I don't think lago and cirros is a catholic wedding. If at some point we must change the image, I think we should, but only if it truly fixes the issues we have and we test it thoroughly enough that it guarantees us major benefits. I more than agree that my recent 'update' to the image does not fall into that category, so we should just test the upstream cirros releases(and hopefully they will release a new 'official' soon).

ifireball commented 7 years ago

@nvgoldin The thing is, since we just need it as an (expensive) testing fixture, I don't think we should place any importance on having up-to-date CirrOS versions. As long as we can make it do what we need it to do, the version should remain static.

nvgoldin commented 7 years ago

@ifireball - I think we agree. I don't see any importance in updating just for the sake of being up-to-date.

nvgoldin commented 7 years ago

https://bugs.launchpad.net/cirros/+bug/1655063