search

lago-project / lago

Ad-hoc virtual testing environment framework
http://lago.readthedocs.org
GNU General Public License v2.0
47 stars 39 forks source link

Throw error if yum install failed in deploy.sh #794

Closed bell-lev closed 5 years ago

bell-lev commented 5 years ago

Currently yum's return code for installing more than one package at a time with the "-y" flag is successful if at least one installation was successful - thus not throwing an error if any package was skipped.

Adding the --setopt=skip_missing_names_on_install=False flag solves this issue.

Source https://bugzilla.redhat.com/show_bug.cgi?id=1274211

ovirt-infra commented 5 years ago

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project. As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.
ovirt-infra commented 5 years ago

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project. As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.
eedri commented 5 years ago

ci test please

eedri commented 5 years ago

ci please test

eedri commented 5 years ago

retriggering to see if fc28 passes

gbenhaim commented 5 years ago

ci test please

gbenhaim commented 5 years ago

ci test please

gbenhaim commented 5 years ago

ci test please

gbenhaim commented 5 years ago

ci merge please