search

lagom / lagom-java.g8

6 stars 15 forks source link

[WIP] Generate Maven Archetype #60

Open ihostage opened 5 years ago

ihostage commented 5 years ago

It's PoC inspired by a phrase of Renato "and the whole idea is to reduce Lagom’s code base" © 😄

My idea is that has only one template for Hello Java example. We can use Giter8 for generating Lagom Maven Archetype and remove the very similar files from https://github.com/lagom/lagom/tree/master/dev/archetypes/maven-java/src/main/resources.

@renatocaval @ignasi35 @marcospereira @dwijnand What do you think?

lightbend-cla-validator commented 5 years ago

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

ihostage commented 5 years ago

Also, I created PR https://github.com/foundweekends/giter8/pull/432. With this feature template for Maven Archetype can will more elegant 😄

ignasi35 commented 5 years ago

Hi @ihostage, thanks for all the effort you've put into this but I see multiple problems.

In the past we thought a single code base with multiple targets was a good idea and it always ended up being a wrong assumption. We tried making a single code base work in both Maven and sbt, we also tried making a single code base deployable to multiple targets (DC/OS-Marathon, Kubernetes,...) and things always get hairy fast.

The Hello World code base is small and stable enough that keeping duplicates is not a big pain. Actually, I think we haven't made any significant change for around 2 years.

But the main issue I see is moving the maven archetype code and publishing away from lagom/lagom since we now introduce 2 problems:

Maven users should not need to install sbt or clone a repo to use an archetype so we must continue to publish the archetype for each version of Lagom we produce.

Having said all this, is there any use case you had in mind that motivates this convergence?

ihostage commented 5 years ago

Maven users should not need to install sbt or clone a repo to use an archetype so we must continue to publish the archetype for each version of Lagom we produce.

@ignasi35 You absolutely right 😉 But I did not offer to migrate release pipeline of Maven Archetype to this repository 😄 It's an only first step for start discussing. 😄 It's good that Maven Archetype releasing with Lagom together. 👍 But I thought that if we can generate Maven Archetype by G8, we can use this repository on Lagom release pipeline. For example, we can use git submodule or maybe more easy solution if will find.

My hight-level proposal maybe writes as:

  1. Remove duplicate Java source of Hello World from Lagom repository
  2. Run sbt new (or g8 directly) on Lagom repository before packaging Maven Archetype.

By the way, Hello World for Maven and Sbt are different now 😄 Sbt template has not integration tests.

ihostage commented 5 years ago

Anyway, exploring this idea I implemented one feature for G8 and this already no zero result 😂