search

lagom / lagom-recipes

Other
62 stars 35 forks source link

Added CircuitBreakerPanel demo project - java - maven #29

Closed silver-soule closed 6 years ago

silver-soule commented 6 years ago

This PR adds a lagom project to demonstrate CircuitBreakerPanel added in lagom 1.4.x along with exception whitelist as per discussion at https://github.com/lagom/lagom/issues/1248 . Please review it and let me know if there are some changes I should do.

Marking it as WIP while I work on a niceish README.

silver-soule commented 6 years ago

@ignasi35 Did the changes you suggested and added a README file, please take a look and let me know if there is something that can be improved :)

silver-soule commented 6 years ago

@ignasi35 moved this out of [WIP] as done with the changes and added the README, let me know if any further changes are required . :)

ignasi35 commented 6 years ago

hi @silver-soule, this looks great.

I'd like one last peek by one of my colleagues since there's been few changes since their last review but it LGTM.

Thanks for your continued effort.