lagom / lagom-recipes

Other
62 stars 35 forks source link

hello-java-maven example with k8s deployment scripts #41

Closed octonato closed 6 years ago

octonato commented 6 years ago

This is an example that uses reactive-lib and maven (but not sbt-reactive-app plugin, obviously) and provides k8s yml files to deploy the services.

The generated docker containers do not have any metadata (labels) and cannot be used with the rp tool. The yml files are generated by hand.

The rp-application.conf is also hand-written and it's stripped down to a minimal.

Services uses Akka Cluster Bootstrap for cluster formation and reactive-lib ServiceLocator based on akka-dns.

TODOs

ignasi35 commented 6 years ago

Hi @renatocaval the filecount on this PR looked weird and I noticed you've pushed some IDE-specific files (.settings/, .project, .classpath, xyz.iml, ...) is that intentional?

If those were pushed by mistake I guess the .gitignore in the root of the repo is incomplete.

ignasi35 commented 6 years ago

I think integration-tests/ should be removed too.

Let's put this PR on a diet: If we could remove stream-xxx and the persitence code in hello-xxx it'd be great.

octonato commented 6 years ago

sure, for the eclipse files. I will remove it and do a force --push

also for the integration-tests

The stream and persistence I don't agree. I think we should be able to show how:

octonato commented 6 years ago

Removed what I mentioned above. Still, 2894 lines!

TimMoore commented 6 years ago

Agree that it's important to demonstrate end-to-end communication, Cassandra and Kafka.

octonato commented 6 years ago

fixed conflicts, I will wait for Travis to merge