search

lagom / lagom-recipes

Other
62 stars 35 forks source link

Couchbase persistence recipe #59

Closed johanandren closed 5 years ago

johanandren commented 5 years ago

Continuation on @ygree s work in #56

johanandren commented 5 years ago

I think what is missing is this part: https://github.com/lagom/lagom-recipes/pull/59/files#diff-ec4623c0086db747c4e35c01562828deR12

ignasi35 commented 5 years ago

Prefer couchbase-persistence-java-mvn and couchbase-persistence-scala-sbt for the folder names of each recipe.

ignasi35 commented 5 years ago

I love the #couchbase-begin/#couchebase-end idea. Makes it very easy to search and find specific bits of code.

I think we should remove all the recycled comments (specially those coming directly from the hello template) and we could add (at least) one comment for each #couchbase-begin/#couchebase-end block.

johanandren commented 5 years ago

Would be ok to merge this and that someone from the Lagom team picked it up? I think that would be much faster for the repository-best-practice changes.

ignasi35 commented 5 years ago

Sure! Once travis is green I'll squash-merge it and pick it up.

johanandren commented 5 years ago

Excellent, thanks!