Open marvinmarnold opened 5 years ago
CLA now signed
@marvinmarnold What a key difference with the recipe for H2? It's very difficult to find her manually 😞
@marvinmarnold What a key difference with the recipe for H2? It's very difficult to find her manually 😞
It's on the README
. I actually liked that the README
states a starting point and details the necessary changes focusing the user attention.
It's on the
README
. I actually liked that theREADME
states a starting point and details the necessary changes focusing the user attention.
Thank you, @ignasi35 ! I found it 😄
@marvinmarnold, we are planning to reduce the number of recipes/samples we have to maintain.
One of the recipes we plan to keep is the mixed persistence, but I don't think it's worth having another mixed-persistence recipe that is basically the same but only changing the underlying RDBMS. This will only increase the surface of things we need to maintain.
On the other hand, we want to have a place where community members can publish their samples/recipes projects. With that in mind, the upcoming lagom-samples
project will contain a section on its README.md
pointing to community supported samples/recipes and we would prefer to have this recipe living on your repo and we link to it, instead of merging it here.
Would that be a good solution for you?
@renatocaval yea that sounds like a good idea. I'll try to go through the other comments soon and make some final improvements in the meantime.
Hi @marvinmarnold,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
http://www.lightbend.com/contribute/cla