lagom / lagom-recipes

Other
62 stars 35 forks source link

Created separate recipe for cassandra write and postgres read side #66

Open marvinmarnold opened 5 years ago

lightbend-cla-validator commented 5 years ago

Hi @marvinmarnold,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

marvinmarnold commented 5 years ago

CLA now signed

ihostage commented 5 years ago

@marvinmarnold What a key difference with the recipe for H2? It's very difficult to find her manually 😞

ignasi35 commented 5 years ago

@marvinmarnold What a key difference with the recipe for H2? It's very difficult to find her manually 😞

It's on the README. I actually liked that the README states a starting point and details the necessary changes focusing the user attention.

ihostage commented 5 years ago

It's on the README. I actually liked that the README states a starting point and details the necessary changes focusing the user attention.

Thank you, @ignasi35 ! I found it 😄

octonato commented 5 years ago

@marvinmarnold, we are planning to reduce the number of recipes/samples we have to maintain.

One of the recipes we plan to keep is the mixed persistence, but I don't think it's worth having another mixed-persistence recipe that is basically the same but only changing the underlying RDBMS. This will only increase the surface of things we need to maintain.

On the other hand, we want to have a place where community members can publish their samples/recipes projects. With that in mind, the upcoming lagom-samples project will contain a section on its README.md pointing to community supported samples/recipes and we would prefer to have this recipe living on your repo and we link to it, instead of merging it here.

Would that be a good solution for you?

marvinmarnold commented 5 years ago

@renatocaval yea that sounds like a good idea. I'll try to go through the other comments soon and make some final improvements in the meantime.