search

lagom / lagom-samples

https://developer.lightbend.com/start/?group=lagom
Creative Commons Zero v1.0 Universal
86 stars 82 forks source link

Use latest JDKs #107

Closed ignasi35 closed 5 years ago

TimMoore commented 5 years ago

Travis CI didn't run on this change. Any ideas why?

TimMoore commented 5 years ago

Looking at https://travis-ci.com/lagom/lagom-samples/requests, my guess is that this pull request initially targeted the wrong branch, and Travis CI doesn't see an event when the branch target is updated. I'll close and reopen to trigger it.

We should probably also set it up as a required check for the 1.5.x and 1.6.x branches, so that things aren't merged by mistake without the build running. Update: raised as #108.

TimMoore commented 5 years ago

Had to update the Java 8 version string: 37c2f75

TimMoore commented 5 years ago

Backport: #110

ignasi35 commented 5 years ago

Had to update the Java 8 version string: 37c2f75

thanks @TimMoore

ignasi35 commented 5 years ago

Is there any easier way to specify the latest patch build of each release? Otherwise this will be a constant chore.

There certainly is. We should use the same spell we use on other repos.

ignasi35 commented 5 years ago

raised #111