search

lagom / lagom-samples

https://developer.lightbend.com/start/?group=lagom
Creative Commons Zero v1.0 Universal
86 stars 82 forks source link

[1.5.x] Use latest JDKs #110

Closed TimMoore closed 5 years ago

TimMoore commented 5 years ago

Backport of #107

TimMoore commented 5 years ago

Should 1.5.x actually be running with Java 11? It already was, before this pull request, but Cassandra seems flaky in CI. We don't certify Lagom 1.5 with Java 11. Should I remove it from this branch?

ignasi35 commented 5 years ago

Should 1.5.x actually be running with Java 11? It already was, before this pull request, but Cassandra seems flaky in CI. We don't certify Lagom 1.5 with Java 11. Should I remove it from this branch?

We already run the lagom/lagom build jobs in JDK11. We could mark the JDK11 jobs for lagom-samples as may fail but I think we must keep them around.

TimMoore commented 5 years ago

The build passed after re-running, so the only thing blocking this now is an erroneously required "Travis CI - Branch" check (see https://github.com/lagom/lagom-samples/pull/114#discussion_r335839087).

TimMoore commented 5 years ago

I manually removed that required check (since the settings bot seems to be broken) so this just needs an approval from someone.