lagom / lagom

Reactive Microservices for the JVM

https://www.lagomframework.com

Apache License 2.0

2.63k stars 634 forks source link

Update scala-xml to 2.0.1 #3330

Closed magro closed 2 years ago

magro commented 2 years ago

Pull Request Checklist

[x] Have you read through the contributor guidelines?
[x] Have you signed the Lightbend CLA?
[x] Have you added copyright headers to new files?
[x] Have you updated the documentation?
[x] Have you added tests for any changed functionality?

Fixes

Updates scala-xml to the latest version

Purpose

Prevent binary incompatibilities with libs using a newer version of scala-xml in applications using lagom - prevent app developers from running into lib version conflicts

Background Context

References

lightbend-cla-validator commented 2 years ago

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

an-tex commented 2 years ago

same issue with latest scala-test update https://github.com/scalatest/scalatest/issues/2092

octonato commented 2 years ago

@magro, sorry that I missed this PR.

I'm retiring the master branch and we need to bring this change into main now. I tried to repoint your PR to the main branch, but that won't work.

That said, I cherry-picked your change here https://github.com/lagom/lagom/pull/3333, preserving the authorship and I will close this PR.

magro commented 2 years ago

Cool, thanks @octonato!