search

lagom / online-auction-java

Other
129 stars 109 forks source link

User Lookup #143

Closed lakhina closed 7 years ago

TimMoore commented 7 years ago

@lakhina could you provide a little description of the reason for this change please? How does it fit into the bigger picture? Who will be subscribing to these events and how will they be used?

lakhina commented 7 years ago

@TimMoore As you mentioned in issue #120 We could publish user events to Kafka, and have the web-gateway listen to these events and maintain its own internal copy of user display names.

I am just trying to do this for user Lookup. If there is any other way to create user lookup that would be easier than this than you can suggest it and I will then work accordingly.

TimMoore commented 7 years ago

@lakhina ... I see. That was one part of a larger comment. Sorry that it was unclear. I've raised #145 with a more detailed description of what I was expecting.

In #120, I mentioned that publishing user events to Kafka and subscribing to them in web-gateway is a possible optimization that could speed it up and make it more resilient if the user service is down for some reason, but it is a more complex solution, and I'm not sure the extra complexity is worth it.

lakhina commented 7 years ago

@TimMoore Can you please review? There are still some errors on running.

lakhina commented 7 years ago

@ignasi35 @TimMoore Please review.

lakhina commented 7 years ago

@TimMoore I will make the suggested changes asap.

lakhina commented 7 years ago

@ignasi35 Please review

lakhina commented 7 years ago

@TimMoore @ignasi35 Please review