Add feature on Transaction Service: Submit payment status (approved/rejected)

lagom / online-auction-java

Other

129 stars 109 forks source link

Add feature on Transaction Service: Submit payment status (approved/rejected) #151

Closed yg-apaza closed 7 years ago

yg-apaza commented 7 years ago

[x] Add entity tests, service tests, repository tests
[x] Update TransactionEntity, TransactionServiceImpl and TransactionRepository

yg-apaza commented 7 years ago

@TimMoore @ignasi35 I made the suggested changes, please review

ignasi35 commented 7 years ago

LGTM, @TimMoore do you have any further comment?

yg-apaza commented 7 years ago

Yes, I'll do the UI part in another pull request

TimMoore commented 7 years ago

OK sounds good @yg-apaza. In that case, please update the title of the pull request to describe what is actually implemented. The phrasing used now is in the style of a user story, which suggests that it is a complete end-to-end implementation.

yg-apaza commented 7 years ago

I updated the title, how about now @TimMoore ?

TimMoore commented 7 years ago

Thanks!