search

lagom / online-auction-java

Other
129 stars 109 forks source link

Bumps to Lagom 1.4.1. Fixes some ExCtx issues #167

Closed ignasi35 closed 6 years ago

ignasi35 commented 6 years ago

Bumps Lagom to 1.4.1.

While testing I noticed a couple of controllers failed because the CompletionStage composition required the explicit ExecutionContext.

ignasi35 commented 6 years ago

I've done a rather extensive manual test of the (including search features). Keeping an eye on terminal logs too.

With the changes suggested in this PR everything seems to work.

Hmm, not sure I tested the login operation (I did test signup and logout, though). 🤔

TimMoore commented 6 years ago

Easier to review with the secret "ignore whitespace" URL: https://github.com/lagom/online-auction-java/pull/167/files?w=1

TimMoore commented 6 years ago

Login page is in fact broken

TimMoore commented 6 years ago

It looks like the entire login function is broken. I suggest that we leave that out of this pull request.

TimMoore commented 6 years ago

I pushed my WIP changes to the login controller, but the back-end service also needs to be fixed.

TimMoore commented 6 years ago

Tests repeatedly timed out, so I increased the timeout duration.

ignasi35 commented 6 years ago

Thanks @TimMoore !