search

lagom / sbt-lagom-descriptor-generator

Lagom API code generator
Apache License 2.0
23 stars 12 forks source link

fix error replacing '.' by file separator on windows #26

Closed fjavierjimenez closed 7 years ago

fjavierjimenez commented 7 years ago

When executing integration tests on windows gives the following error:

[info] - should generate a Lagom Scala Descriptor given an OpenAPI v2 file *** FAILED *** [info] java.lang.IllegalArgumentException: character to be escaped is missing [info] at java.util.regex.Matcher.appendReplacement(Matcher.java:809) [info] at java.util.regex.Matcher.replaceAll(Matcher.java:955) [info] at java.lang.String.replaceAll(String.java:2223) [info] at com.lightbend.lagom.spec.render.LagomScalaRender$.com$lightbend$lagom$spec$render$LagomScalaRender$$getPath(LagomScalaRender.scala:34) [info] at com.lightbend.lagom.spec.render.LagomScalaRender$$anonfun$1.apply(LagomScalaRender.scala:20) [info] at com.lightbend.lagom.spec.render.LagomScalaRender$$anonfun$1.apply(LagomScalaRender.scala:19) [info] at scala.Function1$$anonfun$andThen$1.apply(Function1.scala:55) [info] at com.lightbend.lagom.spec.LagomGenerator$class.generate(LagomGenerator.scala:34) [info] at com.lightbend.lagom.spec.LagomGenerators$$anon$2.generate(LagomGenerators.scala:26) [info] at com.lightbend.lagom.spec.LagomGenerators$.openApiV2ToLagomScala(LagomGenerators.scala:26)

So the file separator \'\' have to be escaped when replacing '.'

Also, the tests have been changed due to line separator differences beetween windows and unix

ignasi35 commented 7 years ago

Awesome! Thanks @fjavierjimenez