search

lagotto / alm-report

ALM Reports
http://almreports.plos.org/
MIT License
8 stars 3 forks source link

Download metrics CSV file broken (test.parascope.io) #112

Closed jenniferlin15 closed 9 years ago

jenniferlin15 commented 9 years ago

I clicked to download the CSV file and received an error: We're sorry, but something went wrong.. URL: http://test.parascope.io/reports/download_data/13.csv

I'm using Firefox 31.0 browser. Error received 7.20pm PT, Dec 11.

jure commented 9 years ago

There's a spec for download CSV https://github.com/articlemetrics/alm-report/blob/master/spec/features/export_report_as_csv_spec.rb, which is passing for the general case. I'll include this edge case and fix the issue.

jure commented 9 years ago

Looks like it's an issue with affiliations:

NoMethodError (undefined method `keys' for nil:NilClass):
  app/models/geocode.rb:90:in `load_from_addresses'
  app/models/search_result.rb:94:in `affiliations'
  app/models/report_doi.rb:30:in `csv_row'
  app/models/report_doi.rb:12:in `to_csv'
  app/models/report.rb:100:in `block (2 levels) in to_csv'
  app/models/report.rb:98:in `block in to_csv'
  app/models/report.rb:87:in `to_csv'
  app/controllers/reports_controller.rb:141:in `block (2 levels) in download_data'
  app/controllers/reports_controller.rb:140:in `download_data'
  app/controllers/application_controller.rb:41:in `save_session_dois'

The DOIs in the failing report are:

10.1371/journal.pbio.0060048
10.1371/journal.pbio.0050082
10.1371/journal.pone.0006901
10.1371/journal.pgen.1004293
10.1371/journal.pone.0077033
10.1371/journal.pgen.1000829
10.1371/journal.pgen.1000247
10.1371/journal.pone.0030288
10.1371/journal.pone.0053778
10.1371/journal.pbio.1000224
10.1371/journal.pntd.0000411
10.1371/journal.pone.0071820
10.1371/journal.pone.0010071
10.1371/journal.pone.0113899
10.1371/annotation/c1aa88dd-4360-4902-8599-4d7edca79817
10.1371/journal.pone.0062510
10.1371/journal.pmed.0010031
10.1371/journal.pone.0088631
10.1371/journal.pcbi.0010004
10.1371/journal.pbio.1001884
10.1371/journal.pbio.1001757
10.1371/journal.pone.0002566
10.1371/journal.pgen.1000268
10.1371/journal.pbio.1001677
10.1371/journal.pone.0025841
mfenner commented 9 years ago

What is that .alm at the end?

jure commented 9 years ago

Oh, sorry, I missed that, that's just the cache keys. They're DOI + ".alm" (pre-existing code, not mine yet).