search

lagotto / alm-report

ALM Reports
http://almreports.plos.org/
MIT License
8 stars 3 forks source link

About, Terms of Use and Privacy Policy text #12

Closed jure closed 10 years ago

jure commented 10 years ago

At this point these texts are PLOS specific, should these be updated with generic versions too? There is a fair amount of legalese involved here, especially in Terms of Use and Privacy Policy, not really sure how (or if) to proceed.

mfenner commented 10 years ago

Let me check on this, but I think it makes most sense to make this specific to the PLOS version of the application, as the terms of use are really about the PLOS instance of the software, not someone installing the open source version. Maybe this file should be merged in later from a PLOS version of the software (we need to do this anyway because our capistrano configuration needs files from the repo).

jure commented 10 years ago

OK, I guess in the context of the open source app, it would make sense to just show the About page then, with a sans-PLOS version of that description.

Also, less merging, more fun. A bit off topic, but can't the configuration files that capistrano needs, be in a separate private git repository that just gets cloned into alm-report repo as a submodule in config/capistrano or something like that? Merging constantly will only get trickier.

mfenner commented 10 years ago

I hate merging for deployment, but I had submodules even more. Currently puma and configuration settings are in the private repo, but I hope to get them out of version control (and into a configuration management tool) at some point.

jure commented 10 years ago

Ah, yes, OK, submodules are not the right solution either, that's a valid point. But definitely :+1: for moving configuration into a configuration management tool.

jure commented 10 years ago

OK, so for now, we've hidden the About, Terms of Use and Privacy Policy links in the default mode, see pull request #20. I'll leave this issue open while it's being decided if these texts will be replaced by something or not.

mfenner commented 10 years ago

We have discussed this, and want to remove Terms of Use and Privacy policy from both modes. About is linked from the default mode in the header and that is fine. Also, no more dicussions about MIT license needed.

jure commented 10 years ago

Jolly good, I'll get right on that.