search

lagotto / alm-report

ALM Reports
http://almreports.plos.org/
MIT License
8 stars 3 forks source link

WIP: User profile #129

Closed mfenner closed 9 years ago

mfenner commented 9 years ago

Using devise and omniauth, with support for persona, cas, orcid, and github.

In this first iteration we start with a minimal profile.

jure commented 9 years ago

It looks good, but I'd like to see some specs if possible. I know it's a bit tricky with OAuth, but it's not terrible either: http://natashatherobot.com/rails-test-omniauth-sessions-controller/

mfenner commented 9 years ago

yes, rspec support is the next step - the lagotto tests are in cucumber. Do you want to avoid FactoryGirl?

jure commented 9 years ago

I have nothing against FactoryGirl, so go ahead. But it would be nice if the specs were indeed in RSpec and not Cucumber, to keep things in one place. Cucumber is >> better than nothing though, so if you're pressed for time, just port those.