search

lagotto / alm-report

ALM Reports
http://almreports.plos.org/
MIT License
8 stars 3 forks source link

Selecting articles is broken in some configurations #16

Closed mfenner closed 10 years ago

mfenner commented 10 years ago

The Javascript that selects articles doesn't seem to work, at least in some configurations.

jure commented 10 years ago

Can you be a bit more specific? Trying locally it works fine, select deselect, select all, etc.

Edit: JS in general seems broken on the deployed version though, something about browser, msie and undefined. I'll take a look, the error is in jquery.uniform.js.

mfenner commented 10 years ago

Yes, probably a more general JS problems in the deployed version. Locally it works for me as well.

jure commented 10 years ago

OK Martin this is a bug I fixed with https://github.com/articlemetrics/alm-report/commit/df976715caba6eeccc5d2554725954753b614c8a so I'm not really sure how this JS is deployed at this point.

And it definitely is deployed, the latest master has jQuery.uniform 2.1.0, and the deployed version is 2.0.0

Uniform v2.0.0
Copyright © 2009 Josh Pyles / Pixelmatrix Design LLC
http://pixelmatrixdesign.com

No clue how that's possible. Sure you have latest master in the deploy?

mfenner commented 10 years ago

It sure would help if I'd deploy the master branch ;). Let me redeploy the latest master.

mfenner commented 10 years ago

Works fine with the master branch.