search

lagotto / alm-report

ALM Reports
http://almreports.plos.org/
MIT License
8 stars 3 forks source link

Make sure the ALM API returns usage stats for counter and pmc #25

Closed mfenner closed 10 years ago

mfenner commented 10 years ago

This pull requests gracefully handles situations where the ALM API returns no event data for counter or pmc and fixes #13. Added unit tests to confirm that the generate_data_for_usage_chart method works as expected. Also made a small tweak to the Javascript handling the missing data.

mfenner commented 10 years ago

I didn't want to create test fixtures, as this project is probably moving to factories soon. I tried to change the existing code as little as possible, in the future we might consider refactoring some of the methods for easier unit testing.

jure commented 10 years ago

Looking good Martin, thanks! Merging.