lagunovsky / redux-react-router

A Redux binding for React Router v6
MIT License
72 stars 9 forks source link

Types Improvement #7

Closed faminchik closed 2 years ago

faminchik commented 2 years ago

After transition to a Functional Component, two component properties (enableTimeTravelling, routerSelector) became required.

In the previous implementation (Class Component) this was handled by the react types since the defaultProps object contained these properties. Now, using a Functional Component, these properties should be explicitly marked as optional to comply the previous library typing.

lagunovsky commented 2 years ago

My mistake.

Thank you!