search

lah7 / gtk3-classic

Patches to bring back a traditional experience for GTK+3
Other
338 stars 24 forks source link

Add atk-bridge patches and make dbus dependency optional #101

Closed stefan11111 closed 1 year ago

stefan11111 commented 1 year ago

I don't know if these patches are right for this project, but here are the patches for making the dependency on dbus optional by disabling atk-bridge. I tried my luck with upstream, but they said no and stopped responding.

stefan11111 commented 1 year ago

Setting it to be enabled by default, like you proposed, is the better choice. I copied the patches from my gentoo patches directory, where I had to set it to default-disabled because there is no way to toggle it without a patched ebuild.

I suspect something similar might need to be done for the gentoo ebuild for these patches, given that it's supposed to work alongside gtk+ from ::gentoo. Maybe a use flag to switch between adding these patches or not.

Also, I am really curious how you manage to dig out there old upstream commits. Is there a tool to search through commits?

lah7 commented 1 year ago

Not familiar with Gentoo myself, but as this default arrangement works then it's all good. I'll get this merged.

Also, I am really curious how you manage to dig out there old upstream commits. Is there a tool to search through commits?

I didn't find that one - it was from issue #40.

Though, Git's "blame" feature is useful for tracing back how a line of code had changed. There's a "blame" button when looking at a file in GitHub or GitLab. There is also a way to see the file prior to that commit:

Screenshot_20230723_153142

Otherwise, searching within GitHub/GitLab is powerful too - code, issue or commit. From there you could explore the repository to piece together how things came to be.