lah7 / gtk3-classic

Patches to bring back a traditional experience for GTK+3
Other
336 stars 25 forks source link

[Request] Bring back toolbar-style and toolbar-icons-size support #115

Open na0miluv opened 1 month ago

na0miluv commented 1 month ago

What should be patched?

Previous to GTK 3.10, toolbar-style was a setting that allowed you to change the style of toolbars in applications between 4 styles.

Alongide toolbar-style, there was also toolbar-icons-size which used to let you change the size of the toolbar icons between small and large. This also has been hard coded since GTK 3.10

A lot of distros used to ship with "both" as the default while current day distros are forced to use "both-horiz", if they even show any labels on the toolbar, and it would be nice to see it brought back.

Screenshots

Captura de pantalla -2024-09-15 07-51-15 Caja using the hard-coded both-horiz + large-icons style

Captura de pantalla -2024-09-15 07-52-06 Geany using both + small-icons style, this and Pluma are the only ones that can still be changed because of the way they implemented it.

Commits

Couldn't find an exact commit but here is the proof of the removal https://gitlab.gnome.org/search?group_id=8&project_id=665&repository_ref=main&scope=blobs&search=toolbar-style

lah7 commented 1 month ago

The good news is that this setting still exists in GTK 3.24.x, but it's hidden behind a dconf property. The proof you found removes it in GTK 4.

Install/use dconf-editor (or use dconf in a terminal) to go here:

Where you'll find:

image

Changing these settings and relaunching certain apps (like Meld) will reflect these changes. Like you noticed, apps like Geany can control the style in their own code, but thankfully Geany does offer options to change it. For MATE apps... well... that's the bad news. Looks like they don't read that setting, so it needs adding for each MATE app. Caja hasn't, but Atril did.

A patch for gtk3-classic could work, something could optionally force the toolbar style via an environment variable - pull requests welcome!

PS. What's the name of that icon theme? Looks pretty nice!

na0miluv commented 1 month ago

For MATE apps... well... that's the bad news. Looks like they don't read that setting, so it needs adding for each MATE app.

Ah damn, well that explains why changing it on both gnome/interface and mate/interface didn't do anything.

A patch for gtk3-classic could work, something could optionally force the toolbar style via an environment variable - pull requests welcome!

I'll try making it an environment variable and see if it works, which I'm hoping it does :'(

PS. What's the name of that icon theme? Looks pretty nice!

It's RedHat's old Bluecurve theme (icons and GTK theme ported to GTK 3 and 4!)