lah7 / gtk3-classic

Patches to bring back a traditional experience for GTK+3
Other
338 stars 24 forks source link

Recommendation: Use gtk3-filechooser-icon-view Patch #67

Closed brocashelm closed 1 year ago

brocashelm commented 2 years ago

Hello, I saw there's a fork of GTK's filechooser that fixes the infamous bug and would like to suggest this patch be integrated into your builds. There's already an AUR build for Arch GNU/Linux, but it otherwise requires building from source.

https://github.com/Dudemanguy/gtk

Thank you.

luigifab commented 2 years ago

It seems that there is "only" one commit.

Impeta commented 2 years ago

I don't mean to rush, but has anything been done yet about this? I would love if this could be applied on, so to save the trouble of many others on installing xdg-portal's KDE counterpart just for the appropriate thumbnails and not feel a jarring unnoticeable contrast of Gtk and QT.

mid-kid commented 1 year ago

It's not incredibly hard to apply this patch on top of gtk3-classic, the main issue being that they make the exact same changes with slightly different code in places, so gtk3-filechooser-icon-view needs to be adapted to remove those.

The reason I wouldn't add it on top of gtk3-classic is twofold: it requires extra setup (glib-thumbnailer + tumbler), and it is just very very very buggy. More often than not it crashes my firefox when trying to save a file.

lah7 commented 1 year ago

Thanks for the recommendation and comments. I agree with @mid-kid's comment, it wouldn't be wise to include it here.

This project is supposed to patch GTK 3 in a way that restores classic GTK look & feel. You can of course make changes to your copy of the AUR package and add lines that unpatch our conflicting patch then apply their diff.

mid-kid commented 1 year ago

I've recently published my patchset, along with a modified filechooser icon view patch, if anyone is interested: https://github.com/mid-kid/gentoo-config/blob/master/patches/x11-libs/gtk%2B:3/9001-gtk3-filechooser-icon-view.patch