lah7 / gtk3-classic

Patches to bring back a traditional experience for GTK+3
Other
338 stars 24 forks source link

Request: No Deadkeys Underline #70

Closed Okxa closed 2 years ago

Okxa commented 2 years ago

What should be patched?

When typing characters with deadkeys, gtk3 currently shows an underline, which is very annoying to some people (such as myself).

Example:

  1. Type a letter a
  2. press ` it shows an underline.

Approach

There is already an patched version of gtk3 on AUR, using this patch:

diff --git a/gtk/gtkimcontextsimple.c b/gtk/gtkimcontextsimple.c
index a7ac95e47c..237ddc0e72 100644
--- a/gtk/gtkimcontextsimple.c
+++ b/gtk/gtkimcontextsimple.c
@@ -1115,7 +1115,7 @@ gtk_im_context_simple_get_preedit_string (GtkIMContext   *context,
                   gunichar ch;
                   gboolean need_space;

-                  if (is_dead_key (priv->compose_buffer[i]))
+                  if (FALSE && is_dead_key (priv->compose_buffer[i]))
                     {
                       ch = dead_key_to_unicode (priv->compose_buffer[i], &need_space);
                       if (ch)

I already tested the patch with the gtk3-classic PKGBUILD, by manually adding the patch file to the folder (and in PKGBUILD sources) and patching with patch -p1 < ../no_deadkeys_underline.patch in prepare(), however you might want to add it to your patching system.

If this is something you might want to add.

EDIT: It seems that this is related: #37, closing this and commenting on that.