search

lah7 / gtk3-classic

Patches to bring back a traditional experience for GTK+3
Other
338 stars 24 forks source link

PKGBUILD: Suggested dependency changes #73

Closed lah7 closed 2 years ago

lah7 commented 2 years ago

As suggested by comment:

+1: please kindly enable the following dependencies, to be at parity with the repo version of gtk3:

libcolord (meson: colord=yes) tracker3 (x86_64) (meson: tracker3=yes) (there is no lib32-tracker3 as of now but can be selectively added to only 64-bit build).

Also please add the two cherry-picked patches as in the repo version 3.24.33-3 (adds legacy icons and fixes epiphany FTBFS).

I'd prefer this package didn't introduce unnecessary dependencies unless it is fixing a problem. If it's possible to keep them strictly optional during build time, then that's OK. Users (and myself) prefer this package for being less bloated.

jonathonf commented 2 years ago

Just as a data point, noone should be building packages against gtk3-classic (packages should be built against repo packages in a clean build environment), so a patch fixing a FTBFS against GTK3 isn't something that needs to be included.

lah7 commented 2 years ago

That's true, thanks for the tip! The "legacy icons" patch appears to be included with GTK+ 3.24.34 according to their NEWS, so that's not needed either.

So, this task is just changing the build parameter colord=no to colord=auto to enable support if the user happens to have that package installed. This doesn't work for tracker3=auto (which doesn't seem essential)