search

lah7 / gtk3-classic

Patches to bring back a traditional experience for GTK+3
Other
339 stars 24 forks source link

File chooser (XFCE-style) #94

Closed ghost closed 1 year ago

ghost commented 1 year ago

This change modifies the the File Chooser Dialog to look more in line with Thunar (Pixel-perfect with the theme I'm using).

filechooser

Note: I've intentionally left this change off the PKGBUILD as its an appearance change that might look strange outside of an XFCE environment.

EDIT: Perhaps this could go on an XFCE specific branch?

ghost commented 1 year ago

That's fair. I don't recall GTK ever looking [as nice!] as this. This is mostly just for me (making my desktop look consistent). I can see it'd be inconvenient to package additional branches, however, for me it's incredibly convenient to pull down from a separate repository and add it on top of this one.

So I'll close this PR and create a new personal repository (likely named 'gtk3-classic-xfce'), which can then be superset on top of this one. i.e. Apply patches from here for the classic GTK look, and then for a more XFCE-leaning look apply the patch(es) of my personal repository.

As an aside, I appreciate you starting/continuing this crusade. I was just about to start patching GTK myself when I stumbled upon this repository. I am proficient in C (although do despise the way in which it's used in GTK), so I'll take a browse through the open issues and see if I can't help.

lah7 commented 1 year ago

Glad to hear! I take no credit for majority of the patches. The repository passed hands a few times, so I stepped up to keep them rolling along the latest GTK 3 and act as a community hub. Probably the biggest downfall is CSD being broken in newer versions of some apps (#32) - and maybe XFCE (https://github.com/lah7/gtk3-classic/discussions/92).

I think separating XFCE-specific improvements is a good idea. I've added a note in the README. They're just a cat and cp away for those building from source.

https://github.com/simplejack-src/gtk3-classic-xfce