search

laher / goxc

a build tool for Go, with a focus on cross-compiling, packaging and deployment
1.68k stars 79 forks source link

Add deb task configuration allowing the auto-inclusion of resources #109

Open pdf opened 8 years ago

pdf commented 8 years ago

Allows the use of pre/post{inst,rm}, etc scripts. The resources-dir task setting should be set to the parent directory of a debian dir containing the resources.

laher commented 8 years ago

This is great. Thanks for taking the time to dig in and see what's up.

Please go ahead and merge. (see invite).

pdf commented 8 years ago

There's actually a problem with the way debber handles this - resources appears to be the only way to get it to include debian contents in the control, however it doesn't exclude debian from data. Whilst doing the latter would be easy, I feel like these two mechanisms should really be decoupled - that would allow for a top-level debian directory, which feels more normal than having to nest it somewhere.

Happy for me to work up a debber PR to split debian handling out of resources?

laher commented 8 years ago

Yes, thank you. I can't honestly remember the details of how debber works right now (!) but it sounds like a sensible plan.

Please make a PR, and then if it introduces any backwards-incompatibility problems I am happy to just fork it into an 0.4. I never got the API to a point where it seemed 100% right, so I'm happy to take changes on board.

Really I'd love to spend some more time rounding out the debber project, but unfortunately/fortunately I just have a very busy life nowadays. ¯(ツ)/¯

stamp commented 8 years ago

Oh this is perfect! I was just wondering why my maintainer scripts didn't fire when installing the deb files.

When do you guys think this fix can be merged to master? Is there anything I can do to help?

pdf commented 8 years ago

@stamp, I've not forgotten about this, I just haven't had time to get to it yet.

stamp commented 8 years ago

Np

I actually found a workaround. I moved the debian folder to resources/debian instead and now it works fine. Just a warning that the control file is missing but it works great anyway.

pdf commented 8 years ago

If you read my earlier comment (or install the resulting package) you'll discover the undesirable side-effect - a debian directory will also be deployed to the filesystem because it ends up in the data tarball, which is probably not what you want.

stamp commented 8 years ago

I made a fix: https://github.com/debber/debber-v0.3/pull/3

What do you think? Seems to work fine in my environment at least.

laher commented 4 years ago

sorry, this is older than the sun itself. I merged @stamp's debber PR FWIW. I figure everyone's moved on with their lives since this was created. :shrug: many apologies.