Fullstack-project review

[ShootingStar91]

Fullstack-project review

Hello, this is a review of your fullstack project. You do not need to implement any suggestions for improvement in order to get your credits.

User experience

• The login / register form is excellent. Very polished and stylish in both look and feel.
  • The loading icon in the button is very nice, however after one failed attempt it seems to get stuck, though form can still be submitted by pressing enter.
  • The toasts are very far in the corner on my ultrawide display, and difficult to notice - though it's understandable to not consider the largest displays when designing the website layout, unless your developing on one!
• Once logged in, the app looks very neat, is simple to use, and looks quite nice even on a wide display.
  • It is not, however, usable on a mobile-sized display. I think that would be quite doable, though it would require some work.
• All features work well and are easy to use
• After clicking the about-page, it's not obvious how to get back. There maybe should be a button like "Get back" on the about page.
• The only complaint I have about the look and feel of the app is that the green buttons that execute some action looked at first like they were disabled. I think that is because the color is quite dim in both the button background and the text. Some minor color adjusting might make it more clickable-looking :smiley: This is a very tiny complaint though.

Code

• The code is clear and well-organized TypeScript on the frontend and JavaScript on the backend.
• State-handling on frontend uses context nicely. However, the reducer setup is quite verbose and it looks like just using one useState for each state would do the same thing with less code and without the extra files. Redux toolkit is installed but it's not used - probably context API is more suitable for an app of this size anyways.
• Otherwise the code is quite nice, utilizing the context's and custom hooks in handy ways.
• On backend, middlewares are used well, and the code is generally simple and well-organized
• The error handling on backend's routes is quite repetitive and inefficient. I recommend using express-async-errors which is presented on the fullstackopen-course. It makes express catch all errors automatically and you can handle them in the errorHandler middleware.

Overall

The application is very polished, easy-to-use and robust website for keeping track of one's job hunting process. The code is good and well-organized TypeScript and JavaScript. The app has plenty of options for expansion, but it was already in a very demoable condition with little bugs and a nice user-experience. Great job! :gem:

[lahmenderpe]

Hello,

Thank you for your in depth UX and code review. Those are some good suggestions and comments :) So, how will I acquire the credits for this project? The credits are not visible on the fullstack open submission page.

[ShootingStar91]

They are already in the system. Perhaps you need a transcript in order to get the credits to your own university.

https://fullstackopen.com/en/part0/general_info#request-a-transcript-of-studies

Please tell me if this does not help