search

lahwaacz / wiki-scripts

Framework for writing bots, maintenance scripts or performing data analysis on wikis powered by MediaWiki
http://lahwaacz.github.io/wiki-scripts/
GNU General Public License v3.0
27 stars 12 forks source link

update "API" class instantiation calls in example scripts #64

Closed agalileev closed 4 years ago

agalileev commented 4 years ago

Hi. It looks like my very first commit belongs to you. :-) I started my research on wiki-scripts and found out, that "diff-revisions.py" example is not working because of API class constructor interface was changed. More commits are coming. (:

lahwaacz commented 4 years ago

Thanks, the examples are indeed outdated.

agalileev commented 4 years ago

Actually i want to start with fully updating examples to better understand how the wiki-scripts work. I should warn that I'm a totally newbie, so any comments on my codestyle/code quality/git and github using are appreciated.

lahwaacz commented 4 years ago

No problem, looking forward to your updates :+1:

agalileev commented 4 years ago

I fixed the API() calls in the example scripts where it was needed. The main thing I understood - it was a bad idea to make the pull request from master to master. :( Some examples scripts are not fixed yet (there are an import error), but I need to read some fine manual about Git. All API() calls are fixed, so if it possible I suggest doing the merge. I want to make further fixes in separate branch on my local repository...

lahwaacz commented 4 years ago

OK, thanks. If you find something broken and incomprehensible, feel free to ask about it any time - better than losing time trying to understand it...