laike9m / Cyberbrain

Python debugging, redefined.
http://bit.ly/cyberbrain-features
MIT License
2.52k stars 160 forks source link

Multiline statement wrong lineno #110

Open laike9m opened 3 years ago

laike9m commented 3 years ago

image

ordinal should be on line 17 not 29, gifts should be on line 32 not 44.

laike9m commented 3 years ago

This issue shouldn't be too hard to fix. We need to modify the map_bytecode_offset_to_lineno function. We can either record a start and end lineno, or use a range to represent lineno.

laike9m commented 3 years ago

For the specific case above, the lineno is correct for Python 3.8 and 3.9.

victorjzsun commented 2 years ago

Linenos are correct for 3.8+ and changes have been made to fix some scenarios in 3.7 in #132

laike9m commented 2 years ago

Can we conclude this bug as fixed? If not, what are the cases left to be fixed?