search

laike9m / PyPunchP2P

Python实现NAT穿透+STUN+TURN+P2P聊天 | Python P2P chat
MIT License
434 stars 170 forks source link

add compatibility with Python3, test with win7 x64 + Python 3.4.2 #1

Closed perillaseed closed 9 years ago

perillaseed commented 9 years ago

add compatibility with Python3, test with both win7 x64 + Python 3.4.2 and win7 x64 + Python 2.7.8

laike9m commented 9 years ago

Thx for your work, I'll test it asap :+1:

laike9m commented 9 years ago

Hi @perillaseed, could you please use 4-space tab and make a new pr? For two reasons:

  1. Most python programmer use 4-space tab so am I
  2. If you change all the indentation, it's hard to find which lines you actually modified, though I looked through all the changes and think it would work for Python3, it's vnot approriate for a repo to have such commits.
perillaseed commented 9 years ago

Ok, I try it.

2015-01-01 14:54 GMT+08:00 Yao Zuo notifications@github.com:

Hi, could you please use 4-space tab and make a new pr? For two reasons:

  1. Most python programmer use 4-space tab so am I
  2. If you change all the indentation, it's hard to find which lines you actually modified, though I looked through all the changes and think it would work for Python3, it's vnot approriate for a repo to have such commits.

— Reply to this email directly or view it on GitHub https://github.com/laike9m/PyPunchP2P/pull/1#issuecomment-68481554.