Closed liwt31 closed 5 years ago
Hi Weitang, I really appreciate your help on making pdir2 better.
I do want to let you know that I'm doing some code refactoring to make it more organized and readable. It should be done by the end of this weekend. I suggest you work on this patch after the change. I apologize if it brings more work for you.
Glad to hear it! Looking forward to seeing a brand new pdir2!
:smile: It won't be "brand new", just want to make things a little better.
Hi, refactoring is done(mostly). Good luck :smile:
support class variable, instance variable, class method
add str method for
AttrType
which makes calls likeprint(pdir().pattrs)
prettierchange test in test_filters from list-based to set-based because the order doesn't seem very important here. (not sure)
the tests are now failing due to
test_pdir_format
because work is still in progress andtest_pdir_format
requires accurate result. If the rest of the PR is approved, then I'll update this test.