Fix _getattr in PrettyDir (#47)

laike9m / pdir2

Pretty dir() printing with joy:beer:

MIT License

1.33k stars 47 forks source link

Fix _getattr in PrettyDir (#47) #48

Closed liwt31 closed 5 years ago

liwt31 commented 5 years ago

Improve the logic of the _getattr
Add format to makefile
Do reformat using black

laike9m commented 5 years ago

Looks good now(please remove xfail though). You want me to merge it now or you have more things to add? For those extra names returned by __dir__, I think we probably need a new category called "unrecognized" or similar word, but that's another thing outside this PR.